-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "Illustration of Transform" docs #7621
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7621
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Unrelated FailuresAs of commit 7bba756: FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base e5bf7cf:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @minhlong94 , made some minor suggestions below but it looks good overall
Here is the doc preview for the gallery: https://docs-preview.pytorch.org/pytorch/vision/7621/auto_examples/plot_transforms.html#sphx-glr-auto-examples-plot-transforms-py |
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Modified as suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @minhlong94 !
…ix lint (#7623) Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Reviewed By: vmoens Differential Revision: D46314045 fbshipit-source-id: 9a1e21bf2064f6ebb15a8da46dc39698bbcaf5b2
Enhance and Reorder sections Illustration of transform documentation page as discussed in #7615. The new section looks as follows:
Resolve: #7615. CC: @pmeier