-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix version wrangling in docs #7600
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7600
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New FailuresAs of commit 196346a: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this Philip, this has been a bit of a pain to manually clean that after every release (and we often forget). This is mostly a stamp but if there's any issue they'll be easy to address
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: vmoens Differential Revision: D46071409 fbshipit-source-id: c8b296144bd7beb4036cb87c975ce94dd1c2e481
We have some logic in our docs that handles the version wrangling for released versions:
vision/docs/source/conf.py
Lines 96 to 105 in abc40ef
Two issues here:
VERSION
environment value. That is currently not the case.main(
, this is retained for the final version.This PR fixes both issues. I'll send a follow-up PR to the
gh-pages
branch to remediate this for the past two versions.