Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comments for ops LastLevelMaxPool to avoid potential confusion #7593

Merged
merged 13 commits into from
May 18, 2023
Merged

add comments for ops LastLevelMaxPool to avoid potential confusion #7593

Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1ef2eef
Update feature_pyramid_network.py
kkaiwwana May 16, 2023
77dcddf
Merge pull request #1 from iaoqian/iaoqian-patch-1
kkaiwwana May 16, 2023
c8fed6d
bug-fix and test
kkaiwwana May 16, 2023
0b0edc6
Merge pull request #2 from iaoqian/pr
kkaiwwana May 16, 2023
8ecb64b
Update test_ops.py
kkaiwwana May 16, 2023
83d2ce4
Update test_ops.py
kkaiwwana May 16, 2023
0742636
Update test_ops.py
kkaiwwana May 16, 2023
250a42a
Update test_ops.py
kkaiwwana May 16, 2023
0774ea0
Merge branch 'main' into main
kkaiwwana May 16, 2023
708a63c
remove test_lastlevel_maxpool2d
kkaiwwana May 17, 2023
a53f564
add comment for LastLevelMaxPool
kkaiwwana May 17, 2023
edd1f16
Merge branch 'main' into main
kkaiwwana May 17, 2023
a49b786
Update torchvision/ops/feature_pyramid_network.py
NicolasHug May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions torchvision/ops/feature_pyramid_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def forward(self, x: Dict[str, Tensor]) -> Dict[str, Tensor]:

class LastLevelMaxPool(ExtraFPNBlock):
"""
Applies a max_pool2d on top of the last feature map
Applies a max_pool2d (not actual max_pool2d) on top of the last feature map
"""

def forward(
Expand All @@ -216,7 +216,8 @@ def forward(
names: List[str],
) -> Tuple[List[Tensor], List[str]]:
names.append("pool")
x.append(F.max_pool2d(x[-1], 1, 2, 0))
# Use max pooling to simulate stride 2 subsampling
x.append(F.max_pool2d(x[-1], kernel_size=1, stride=2, padding=0))
return x, names


Expand Down