Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert non-deterministic on kernels that use gpuAtomicAdd #7582

Merged
merged 1 commit into from
May 13, 2023
Merged

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented May 12, 2023

Fixes #7579

Signed-off-by: Edward Z. Yang ezyang@meta.com

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
@pytorch-bot
Copy link

pytorch-bot bot commented May 12, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7582

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 6697360:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ezyang , LGTM if CI is happy

@ezyang
Copy link
Contributor Author

ezyang commented May 13, 2023

CI failure looks unrelated

@ezyang ezyang merged commit 9b7c7d3 into main May 13, 2023
@github-actions
Copy link

Hey @ezyang!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request May 16, 2023
)

Summary: Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Reviewed By: vmoens

Differential Revision: D45903817

fbshipit-source-id: 998ee3bb2eecbed081f14d6ef37413c7d8014822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect torch.use_deterministic_algorithms
3 participants