Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove obsolete pre Pyhton3.8 compat #7559

Merged
merged 2 commits into from
May 9, 2023
Merged

remove obsolete pre Pyhton3.8 compat #7559

merged 2 commits into from
May 9, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented May 5, 2023

We hard-depend on Python >= 3.8, so this is dead code.

@pytorch-bot
Copy link

pytorch-bot bot commented May 5, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7559

Note: Links to docs will display an error until the docs builds have been completed.

❌ 26 New Failures, 2 Pending

As of commit dc047dc:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier pmeier requested a review from NicolasHug May 5, 2023 15:50
NicolasHug
NicolasHug approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, LGTM logic-wise

@pmeier pmeier merged commit 7325517 into pytorch:main May 9, 2023
@pmeier pmeier deleted the py38-compat branch May 9, 2023 10:31
@github-actions
Copy link

github-actions bot commented May 9, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier added the other if you have no clue or if you will manually handle the PR in the release notes label May 9, 2023
facebook-github-bot pushed a commit that referenced this pull request May 15, 2023
@NicolasHug @facebook-github-bot
[fbsync] remove obsolete pre Pyhton3.8 compat (#7559)
9dcd70d 
Reviewed By: vmoens

Differential Revision: D45694872

fbshipit-source-id: 9e0007f7a988821ded40010340c1be5f921df4b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed code quality other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot