[FBcode->GH] torchvision decoder. fix artifacts, blury images for frame dimensions not multiple of 8 (#7523) #7552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not multiple of 8 (pytorch#7523) Summary: Pull Request resolved: pytorch#7523 In MUI we found an artifact for video with resolution 426x426, not equal to 8. We find that root cause is torchvision decoder, which MUI uses extensively Tiny black bar on the right in the image Before the fix {F949912112} After the fix {F949913076} Full video https://pxl.cl/2CN1G https://pxl.cl/2CN1L Differential Revision: D45035410 fbshipit-source-id: 2d4f6a4812df075fc4677e6b96dc2e0029ea6e92
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7552
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 6 New Failures, 1 Unrelated FailureAs of commit 0f68584: NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base 5a9e210:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Tests jobs on linux look fine... merging. Note for self: I'll have to export the formatting fix in de637e5 manually |
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 15, 2023
Summary: This diff should not be synced back to GH (no need, it's already there). I'm adding the [fbsync] prefix manually. This diff corresponds to de637e5 on github which itself is part of #7552. It's a formatting fix for D45035410 which was merged on fbcode with formatting issues. Reviewed By: vmoens Differential Revision: D45522779 fbshipit-source-id: ce9387c781d99584337cb4cdc0656f0ed79c4a74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #7523
In MUI we found an artifact for video with resolution 426x426, not equal to 8. We find that root cause is torchvision decoder, which MUI uses extensively
Tiny black bar on the right in the image
Before the fix
{F949912112}
After the fix
{F949913076}
Full video
https://pxl.cl/2CN1G
https://pxl.cl/2CN1L
Differential Revision: D45035410
fbshipit-source-id: 2d4f6a4812df075fc4677e6b96dc2e0029ea6e92