Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Resize() documentation #7536

Merged
merged 9 commits into from
May 2, 2023
Merged

Fix Resize() documentation #7536

merged 9 commits into from
May 2, 2023

Conversation

dvidgar
Copy link
Contributor

@dvidgar dvidgar commented Apr 25, 2023

The current documentation implies that the computation of Resize() is performed twice in some cases related to the max_size parameter. This is not the case in the code.
This PR fixes the issue.

cc @vfdev-5

David Garcia added 2 commits April 25, 2023 10:50
The current documentation implies that the computation of Resize() is performed twice in some cases related to the ``max_size`` parameter. This is not the case in the code. 
The new description fixes this issue.
The current documentation implies that the computation of Resize() is performed twice in some cases related to the ``max_size`` parameter. This is not the case in the code. 
The new description fixes this issue.
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 25, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7536

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

❌ 27 New Failures, 3 Unrelated Failures

As of commit 15ee097:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base e946e87:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @dvidgar!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dvidgar , I agree the proposed changes are clearer. I made a minor suggestion below. Could you also update the docstring of the v2 transform here?

than ``max_size`` after being resized according to ``size``, then

Thanks!

David Garcia and others added 4 commits April 25, 2023 13:51
@dvidgar
Copy link
Contributor Author

dvidgar commented Apr 26, 2023

Updated, thanks!

@pmeier pmeier requested a review from NicolasHug May 1, 2023 19:09
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is toasted but docs look good, so I'll merge. Thanks for the PR @dvidgar !

@NicolasHug NicolasHug merged commit 912c44f into pytorch:main May 2, 2023
@NicolasHug NicolasHug mentioned this pull request May 3, 2023
facebook-github-bot pushed a commit that referenced this pull request May 15, 2023
Reviewed By: vmoens

Differential Revision: D45522832

fbshipit-source-id: dc56ecb8d9bf4290cedb1b3004a34c6eba6a13f9

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants