-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove android and iOS builds from CI #7524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the quick turnaround on this!
C source lint failure is valid. The rest is bogus. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming we're OK to stop support for the iOS and Android demos (I'm confirming with PMs internally so please don't merge anything until we have confirmation):
This PR also purges all android and iOS functionality and mentions from the repository. I don't see why we want to keep it if we not even have CI running for it, but no strong opinion
I think we could keep them around, with a clear statement in the README(s) that these are completely unmaintained / out of date. They might still be useful externally and they should be fairly easy for users to make them work. So far we only had to update gradle versions and stuff like that - so userwho know what they're doing should be able to get it to work.
I confirmed with product team that:
|
For completion
is not the full story. It is right that we needed to only do that, but we were heavily relying on the CircleCI image for Android builds. This is no longer available through Nova. In #7410 I sunk significant time into getting it to work. Ultimately I did, but I don't know if the build is correct or even works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Philip
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
The android and iOS builds have been unmaintained for a long time now. As discussed in the latest Nova sync, there is no need to keep CI jobs running and we can kill them.
This PR also purges all android and iOS functionality and mentions from the repository. I don't see why we want to keep it if we not even have CI running for it, but no strong opinion. Happy to revert if needed.
cc @seemethere