Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove android and iOS builds from CI #7524

Merged
merged 11 commits into from
May 3, 2023
Merged

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Apr 17, 2023

The android and iOS builds have been unmaintained for a long time now. As discussed in the latest Nova sync, there is no need to keep CI jobs running and we can kill them.

This PR also purges all android and iOS functionality and mentions from the repository. I don't see why we want to keep it if we not even have CI running for it, but no strong opinion. Happy to revert if needed.

cc @seemethere

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 17, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7524

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 22 New Failures, 1 Unrelated Failure

As of commit acf09e7:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base 8fa3aa5:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the quick turnaround on this!

@pmeier
Copy link
Collaborator Author

pmeier commented Apr 17, 2023

C source lint failure is valid. The rest is bogus.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we're OK to stop support for the iOS and Android demos (I'm confirming with PMs internally so please don't merge anything until we have confirmation):

This PR also purges all android and iOS functionality and mentions from the repository. I don't see why we want to keep it if we not even have CI running for it, but no strong opinion

I think we could keep them around, with a clear statement in the README(s) that these are completely unmaintained / out of date. They might still be useful externally and they should be fairly easy for users to make them work. So far we only had to update gradle versions and stuff like that - so userwho know what they're doing should be able to get it to work.

@NicolasHug
Copy link
Member

I confirmed with product team that:

  • it's OK to remove the CI jobs
  • it's OK to deprecate and stop support of the demos
  • it's preferable to keep the android and ios folders around, with a note about their deprecated / unmaintained status

@pmeier pmeier requested a review from NicolasHug May 1, 2023 19:06
@pmeier pmeier changed the title kill android and iOS remove android and iOS builds from CI May 1, 2023
@pmeier pmeier linked an issue May 2, 2023 that may be closed by this pull request
@pmeier
Copy link
Collaborator Author

pmeier commented May 2, 2023

For completion

So far we only had to update gradle versions and stuff like that

is not the full story. It is right that we needed to only do that, but we were heavily relying on the CircleCI image for Android builds. This is no longer available through Nova. In #7410 I sunk significant time into getting it to work. Ultimately I did, but I don't know if the build is correct or even works.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip

@pmeier pmeier merged commit 2b63500 into pytorch:main May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier deleted the kill-mobile branch May 3, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android workflow is broken
5 participants