add example for v2 wrapping for custom datasets #7514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Apr 13, 2023
| # | ||
| # If both :class:`~torchvision.datapoints.BoundingBox`'es and :class:`~torchvision.datapoints.Mask`'s are included in | ||
| # the sample, ``torchvision.transforms.v2`` will transform them both. Meaning, if you don't need both, dropping or | ||
| # at least not wrapping the obsolete parts, can lead to a significant performance boost. |
There was a problem hiding this comment.
not wrapping the obsolete parts
This works due to the heuristic we have in place. I wonder if we should link to the explanation here or refrain from it to avoid confusion.
| @@ -101,6 +164,7 @@ | |||
| # Since for most operations involving datapoints, it cannot be safely inferred whether the result should retain the | |||
| # datapoint type, we choose to return a plain tensor instead of a datapoint (this might change, see note below): | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
flake8 was complaining here. No idea why this wasn't the case before.
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 26, 2023
Reviewed By: vmoens Differential Revision: D45183670 fbshipit-source-id: 22d4aee4bccb08249bd041448bdaf1205c55c57c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6753 (comment).
cc @praxxus11