Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image_id to the default return for wrapped CocoDetection #7511

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Apr 12, 2023

This is useful for debugging and is also used by our evaluation logic in the references:

res = {target["image_id"].item(): output for target, output in zip(targets, outputs)}

Going from 3 to 4 elements only has a negligible effect on the performance.

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 12, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7511

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 71d7e81:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, LGTM if/when green

@pmeier pmeier merged commit 2975710 into pytorch:main Apr 13, 2023
@pmeier pmeier deleted the image-id-wrapper branch April 13, 2023 07:30
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Apr 24, 2023
…#7511)

Reviewed By: vmoens

Differential Revision: D45183675

fbshipit-source-id: 04e7197fda1eaf5bd728cec1e665ebb573170394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants