Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FBCode->GH] Revert "SymIntify roi_align (#7448)" #7483

Closed
wants to merge 1 commit into from

Conversation

NicolasHug
Copy link
Member

This reverts commit 8f2e5c9.

The PR seems to be causing issues externally (#7472) and internally (D44552412)

Closes #7472

@NicolasHug NicolasHug added the revert(ed) For reverted PRs, and PRs that revert other PRs label Mar 31, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 31, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7483

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 Failures, 1 Pending

As of commit d3a2cba:

BROKEN TRUNK - The following jobs failed but were present on the merge base 78c2719:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NicolasHug
Copy link
Member Author

I'm gonna mark it as [FBcode->GH] even though it's not strictly correct. This avoids me having to land #7448 in fbcode.

@NicolasHug NicolasHug changed the title Revert "SymIntify roi_align (#7448)" [FBCode->GH] Revert "SymIntify roi_align (#7448)" Mar 31, 2023
@NicolasHug NicolasHug marked this pull request as draft March 31, 2023 11:34
@NicolasHug
Copy link
Member Author

Keeping it as DRAFT to avoid merging for now as there might be a fix for the internal issue

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp

@NicolasHug NicolasHug closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed revert(ed) For reverted PRs, and PRs that revert other PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: '_OpNamespace' 'torchvision' object has no attribute 'roi_align'
3 participants