Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock viable/strict branch #7479

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Unblock viable/strict branch #7479

merged 1 commit into from
Mar 31, 2023

Conversation

DanilBaibak
Copy link
Contributor

@DanilBaibak DanilBaibak commented Mar 31, 2023 •
edited by pytorch-bot bot
Loading

Unblock viable/strict branch

cc @seemethere

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 31, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7479

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit f1482e8:

BROKEN TRUNK - The following jobs failed but were present on the merge base 872804f:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pmeier
pmeier approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is the corresponding CircleCI group:

vision/.circleci/config.yml

Line 610 in 872804f

build:

Currently it includes the following jobs:

  • Windows wheels
  • Windows conda
  • Android
  • iOS

The workflow is currently red due to the Android job (#7469).

Since the viable/strict branch is not yet used for nightlies, I'm ok with this patch to unblock. However, as soon as this happens, we need to make sure that Windows builds are ok.

@DanilBaibak DanilBaibak merged commit a5ac34d into main Mar 31, 2023
@DanilBaibak DanilBaibak deleted the Unblock-Viable/Strict-Branch branch March 31, 2023 09:02
@github-actions
Copy link

Hey @DanilBaibak!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Apr 24, 2023
@NicolasHug @facebook-github-bot
[fbsync] Unblock viable/strict branch (#7479)
ccdeabb 
Reviewed By: vmoens

Differential Revision: D45183671

fbshipit-source-id: 47b158cceb26c0a5200025f033fd6504e3497304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

Assignees
No one assigned
Labels
cla signed module: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanilBaibak @pmeier @facebook-github-bot