fix ImagePair MAE comparison #7477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7477
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7d5237d: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
approved these changes
Mar 30, 2023
|
Agreed. If we manage to close pytorch/pytorch#97761, there is only native handling of PIL left in our custom implementation. And I don't think it is worth keeping it over that. |
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
Reviewed By: vmoens Differential Revision: D45183672 fbshipit-source-id: 0369e5b4634ed6da2f60eaf4f41bff5d725d36da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_promote_for_comparisonmethod was removed in pytorch/pytorch#96131.