fix test_detection_preset for ssd data augmentation #7447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7447
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pmeier
commented
Mar 22, 2023
| @@ -1875,7 +1875,7 @@ def test_detection_preset(image_type, data_augmentation, to_tensor, sanitize): | |||
| elif data_augmentation == "ssd": | |||
| t = [ | |||
| transforms.RandomPhotometricDistort(p=1), | |||
| transforms.RandomZoomOut(fill=defaultdict(lambda: (123.0, 117.0, 104.0), {datapoints.Mask: 0})), | |||
| transforms.RandomZoomOut(fill=defaultdict(lambda: (123.0, 117.0, 104.0), {datapoints.Mask: 0}), p=1), | |||
There was a problem hiding this comment.
Driveby. All other transforms already use p=1. Prior to #7442, by chance this transform was not applied.
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
NicolasHug
pushed a commit
to NicolasHug/vision
that referenced
this pull request
Mar 23, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Reviewed By: vmoens Differential Revision: D44416577 fbshipit-source-id: 3951020abaf72e0634fc96159bd860c0a17aa8e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7442 broke this test. However, this is not a bug in the PR, but rather me forgetting to fix the test setup. #7442 changed the random sampling strategy (see #7442 (comment)), which ultimately leads to a different number of boxes in the final output. As expected, only keeping
RandomPhotometricDistortin the pipeline yields exactly the same results prior and after #7442.cc @vfdev-5