Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the typo in the "Update viable/strict" workflow. #7441

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

DanilBaibak
Copy link
Contributor

@DanilBaibak DanilBaibak commented Mar 22, 2023

Fixed the typo in the "Update viable/strict" workflow.

cc @seemethere

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 22, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7441

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DanilBaibak! In other workflows that we don't typically run on a PR, we have this extra condition to run them in case the workflow is touched:

on:
pull_request:
paths:
- "test/test_datasets_download.py"
- ".github/failed_schedule_issue_template.md"
- ".github/workflows/tests-schedule.yml"

So here this would be

on:
  pull_request:
    paths:
      - ".github/workflows/update-viablestrict.yml"

In addition, we only perform the actual action like reporting an issue or fast-forwarding the branch in case this happens on a schedule:

- uses: JasonEtco/create-an-issue@v2.4.0
name: Create issue if download tests failed
if: failure() && github.event_name == 'schedule'

With this setup you can avoid typo errors like this when working on the workflow, while not changing the actual functionality.

@DanilBaibak
Copy link
Contributor Author

Yeah, let's add a trigger by modifying the workflow. Otherwise, it's hard to test the changes.

@pmeier
Copy link
Collaborator

pmeier commented Mar 22, 2023

@DanilBaibak DanilBaibak merged commit b1d16c9 into main Mar 22, 2023
@github-actions
Copy link

Hey @DanilBaibak!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier
Copy link
Collaborator

pmeier commented Mar 22, 2023

facebook-github-bot pushed a commit that referenced this pull request Mar 30, 2023
Reviewed By: vmoens

Differential Revision: D44416553

fbshipit-source-id: e91cf46c5c8f4ed17d777be6ad8109f0baaf8286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants