-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the typo in the "Update viable/strict" workflow. #7441
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7441
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @DanilBaibak! In other workflows that we don't typically run on a PR, we have this extra condition to run them in case the workflow is touched:
vision/.github/workflows/tests-schedule.yml
Lines 3 to 8 in f0a1df3
on: | |
pull_request: | |
paths: | |
- "test/test_datasets_download.py" | |
- ".github/failed_schedule_issue_template.md" | |
- ".github/workflows/tests-schedule.yml" |
So here this would be
on:
pull_request:
paths:
- ".github/workflows/update-viablestrict.yml"
In addition, we only perform the actual action like reporting an issue or fast-forwarding the branch in case this happens on a schedule:
vision/.github/workflows/tests-schedule.yml
Lines 47 to 49 in f0a1df3
- uses: JasonEtco/create-an-issue@v2.4.0 | |
name: Create issue if download tests failed | |
if: failure() && github.event_name == 'schedule' |
With this setup you can avoid typo errors like this when working on the workflow, while not changing the actual functionality.
Yeah, let's add a trigger by modifying the workflow. Otherwise, it's hard to test the changes. |
Hey @DanilBaibak! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: vmoens Differential Revision: D44416553 fbshipit-source-id: e91cf46c5c8f4ed17d777be6ad8109f0baaf8286
Fixed the typo in the "Update viable/strict" workflow.
cc @seemethere