Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proto] Ported RandomIoUCrop from detection refs #6401
[proto] Ported RandomIoUCrop from detection refs #6401
Changes from 15 commits
bf21a25
ed229cd
19076a8
5c2275e
84d2f09
6d664e5
3085dbf
1d06ec3
abf4381
b4fe1a9
3eaacf2
6231608
0b61852
419ba8f
e862e89
f8253aa
4967ae9
79bbe76
b7a5591
1353cfe
c5c46a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@datumbox here is a support for one-hot encoded masks meanwhile other solutions we could decide about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about plain tensors? For
CutMix
andMixUp
we don't allow the "old" image types at all:vision/torchvision/prototype/transforms/_augment.py
Lines 108 to 109 in 162267c
Given that have ported this from references there is no BC constraint to allow plain tensors and PIL images. Still, it feels unnecessary restrictive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To understand your comment, you want to add support for images as Tensors and keep Image and PIL Image ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either that or remove support for PIL here. We should either support all image types or only the "new one" like we do in
CutMix
andMixUp
(not saying this is a good thing, but we should be consistent).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the reason why CutMix, MixUp are not supporting PIL due to lack of implementation ?
Here in RandomIoUCrop we can support everything, so I would add image as torch.Tensor support and keep PIL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should support all types. Part of the API supporting them and part not is weird and will hinter adoption.