Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA 11.6 for TorchVision #5803

Merged
merged 3 commits into from
Apr 21, 2022
Merged

CUDA 11.6 for TorchVision #5803

merged 3 commits into from
Apr 21, 2022

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Apr 11, 2022

CUDA 11.6 for TorchVision

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atalman Thanks for the PR and the clean up.

I've added a question for you below. Moreover one of the tests seems to be failing and it might be related to the changes on the zlib.

packaging/windows/internal/cuda_install.bat Show resolved Hide resolved
packaging/windows/internal/cuda_install.bat Show resolved Hide resolved
@atalman
Copy link
Contributor Author

atalman commented Apr 21, 2022

@atalman Thanks for the PR and the clean up.

I've added a question for you below. Moreover one of the tests seems to be failing and it might be related to the changes on the zlib.

@datumbox This looks like intermittent failure, I think zlib failed to download and install :

Downloading packages:


(1/5): libjpeg-turbo-devel-1.2.90-8.el7.x86_64.rpm         |  99 kB   00:00     


(2/5): libjpeg-turbo-1.2.90-8.el7.x86_64.rpm               | 135 kB   00:00     


(3/5): libpng-1.5.13-8.el7.x86_64.rpm                      | 213 kB   00:00     


(4/5): libpng-devel-1.5.13-8.el7.x86_64.rpm                | 122 kB   00:00     


(5/5): zlib-devel-1.2.7-19.el7_9.x86_64.rpm                |  50 kB   00:00     

--------------------------------------------------------------------------------

Total                                              2.0 MB/s | 618 kB  00:00     
.....
ffmpeg: /lib64/libz.so.1: version `ZLIB_1.2.9' not found (required by /home/circleci/project/env/bin/../lib/././libpng16.so.16)

Error fetching ffmpeg version, ignoring ffmpeg.

FFmpeg found: False

I am not observing this failure anymore: https://app.circleci.com/pipelines/github/pytorch/vision/16683/workflows/e71d659d-5438-41bc-aa39-5955b2b03ba9/jobs/1365614

Downloading packages:


(1/5): libjpeg-turbo-devel-1.2.90-8.el7.x86_64.rpm         |  99 kB   00:00     


(2/5): libpng-devel-1.5.13-8.el7.x86_64.rpm                | 122 kB   00:00     


(3/5): libjpeg-turbo-1.2.90-8.el7.x86_64.rpm               | 135 kB   00:00     


(4/5): libpng-1.5.13-8.el7.x86_64.rpm                      | 213 kB   00:00     


(5/5): zlib-devel-1.2.7-19.el7_9.x86_64.rpm                |  50 kB   00:00     

--------------------------------------------------------------------------------

Total                                              2.5 MB/s | 618 kB  00:00 
....
FFmpeg found: True

ffmpeg include path: ['/home/circleci/project/env/include']

ffmpeg library_dir: ['/home/circleci/project/env/lib']

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit a64c674 into pytorch:main Apr 21, 2022
facebook-github-bot pushed a commit that referenced this pull request May 5, 2022
Summary:

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095705

fbshipit-source-id: 859ffe19fd4e3a27f5423fa9500ba15d929a456d

Co-authored-by: Nikita Shulga <nshulga@fb.com>
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants