-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor BoxOps tests to use parameterize #5380
Conversation
💊 CI failures summary and remediationsAs of commit 619851f (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet.
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
1st commit was failed with lint failure |
@HeungwooLee Thanks! I will have a closer look next week. Just not that the failing linter job is related to you PR. Have a look to this section of the guide on how to setup and use the same linter. Don't worry about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @HeungwooLee. I've added a few comments, let me know what you think.
Just updated with 3rd commit which should address all comments above.
Also updated with 4th commit for first two styling comments. ufmt is keep reverting this change for some reason and had to manually update them and skiped styling check. |
Addressed typing errors and updated PR with new commit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one final comment and we should be good:
@HeungwooLee Thanks for the awesome work, LGTM. |
Summary: * Refactor BoxOps tests to use parameterize * Refactor BoxOps tests to use parameterize * Refactor BoxOps to use parameterize, addressed comments from PR#5380 * Refactor BoxOps to use parameterize, addressed minor styling comments from PR#5380 * Refactor BoxOps to use parameterize, addressed typing errorsfrom PR#5380 * Refactor BoxOps to use parameterize, addressed minor naming comments for PR#5380 Reviewed By: NicolasHug Differential Revision: D34140248 fbshipit-source-id: 3844d49b78b3b8f4d432ef64094b43605d07351e
Closes #4500
Refactored TestBoxArea, TestBoxIoU and TestGenBoxIoU class to not have duplicated code.
pytest test -vvv
: passed