-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI jobs broken due to upstream changes on padding and stride #5873
Comments
This was referenced Apr 25, 2022
peterbell10
added a commit
to pytorch/pytorch
that referenced
this issue
Apr 25, 2022
Fixes pytorch/vision#5873 In the python version of `F.pad`, checking that the fill value was left as default was done by comparing against zero: https://github.com/pytorch/pytorch/blob/bc2c6edaf163b1a1330e37a6e34caf8c553e4755/torch/nn/functional.py#L4366 So if someone does explicitly pass in a zero-value, then this `TORCH_CHECK` was an accidental BC-break. Instead, we should just warn in that case. [ghstack-poisoned]
peterbell10
added a commit
to pytorch/pytorch
that referenced
this issue
Apr 25, 2022
…e is zero" Fixes pytorch/vision#5873 In the python version of `F.pad`, checking that the fill value was left as default was done by comparing against zero: https://github.com/pytorch/pytorch/blob/bc2c6edaf163b1a1330e37a6e34caf8c553e4755/torch/nn/functional.py#L4366 So if someone does explicitly pass in a zero-value, then this `TORCH_CHECK` was an accidental BC-break. [ghstack-poisoned]
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this issue
Apr 25, 2022
This reverts commit 9390609. Fixes pytorch/vision#5873 Pull Request resolved: #76332 Approved by: https://github.com/seemethere
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this issue
Apr 26, 2022
Fixes pytorch/vision#5873 In the python version of `F.pad`, checking that the fill value was left as default was done by comparing against zero: https://github.com/pytorch/pytorch/blob/bc2c6edaf163b1a1330e37a6e34caf8c553e4755/torch/nn/functional.py#L4366 So if someone does explicitly pass in a zero-value, then this `TORCH_CHECK` was an accidental BC-break. Pull Request resolved: #76307 Approved by: https://github.com/albanD, https://github.com/jbschlosser, https://github.com/datumbox
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this issue
Apr 26, 2022
Summary: This reverts commit 9390609. Fixes pytorch/vision#5873 Pull Request resolved: #76332 Approved by: https://github.com/seemethere Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/1d55518198de14a011e7acd6c604afe512ee28b4 Reviewed By: osalpekar Differential Revision: D35938180 Pulled By: zengk95 fbshipit-source-id: 15f48235b3b11ce9ca2379781f9e75cd1af39aed
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this issue
Apr 26, 2022
Summary: Fixes pytorch/vision#5873 In the python version of `F.pad`, checking that the fill value was left as default was done by comparing against zero: https://github.com/pytorch/pytorch/blob/bc2c6edaf163b1a1330e37a6e34caf8c553e4755/torch/nn/functional.py#L4366 So if someone does explicitly pass in a zero-value, then this `TORCH_CHECK` was an accidental BC-break. Pull Request resolved: #76307 Approved by: https://github.com/albanD, https://github.com/jbschlosser, https://github.com/datumbox Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f02b7a9c36dd6182da694bc47a5c345285dfd951 Reviewed By: osalpekar Differential Revision: D35938194 fbshipit-source-id: dabefdded870182ddc198d0e6473009270b895d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Describe the bug
The latest main seems broken potentially due to upstream changes on PyTorch's core. I believe the problem was introduced due to the changes on pad at pytorch/pytorch#73433 and on stride at pytorch/pytorch#72962
Here are different failures we get:
Versions
Latest main e99278a
cc @seemethere
The text was updated successfully, but these errors were encountered: