Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ez][HUD] Better repo for job link if undefined #6320

Merged
merged 3 commits into from
Feb 21, 2025
Merged

[ez][HUD] Better repo for job link if undefined #6320

merged 3 commits into from
Feb 21, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Feb 21, 2025 •
edited
Loading

#6304 broke job links on the testinfo page, so this tries to parse the html url and then falls back to pytorch/pytorch if that fails

This can be checked by going to https://hud.pytorch.org/tests/testInfo?name=test_non_contiguous_tensors_nn_ConvTranspose1d_cuda_complex32&suite=TestModuleCUDA&file=test_modules.py and clicking on the commit link for a job

@vercel Vercel
Copy link

vercel bot commented Feb 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Feb 21, 2025 6:19pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
@clee2000 clee2000 marked this pull request as ready for review February 21, 2025 17:58
@clee2000 clee2000 requested a review from a team February 21, 2025 17:59
ZainRizvi
ZainRizvi approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a hot fix since this is strictly better than the current implementation.

However, what's stopping us from having the job correctly populated with the repo in this situation?

@clee2000
Copy link
Contributor Author

Approving as a hot fix since this is strictly better than the current implementation.

However, what's stopping us from having the job correctly populated with the repo in this situation?

I actually run into a MEMORY_LIMIT_EXCEEDED error on ClickHouse when I try to put it in.

Also swapped to parsing the html url and then falling back to pytorch/pytorch if that doesn't work as well

@clee2000 clee2000 changed the title [ez][HUD] Default repo for job link [ez][HUD] Better repo for job link if undefined Feb 21, 2025
@clee2000 clee2000 merged commit 3b1aa67 into main Feb 21, 2025
6 checks passed
@clee2000 clee2000 deleted the csl/fix_job_link branch February 21, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZainRizvi ZainRizvi ZainRizvi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clee2000 @ZainRizvi @facebook-github-bot