Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows CUDA 12.6 builds #6002

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Add windows CUDA 12.6 builds #6002

merged 2 commits into from
Dec 3, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Dec 2, 2024

Enables windows CUDA 12.6 builds. Since these where enabled on the core

@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm labels Dec 2, 2024
huydhn
huydhn reviewed Dec 2, 2024
View reviewed changes
tools/scripts/generate_binary_build_matrix.py Outdated
"12.4": "pytorch/manylinux-builder:cuda12.4",
"12.6": "pytorch/manylinux2_28-builder:cuda12.6",
"11.8": "pytorch/manylinux-builder:cuda11.8",
"12.1": "pytorch/manylinux-builder:cuda12.1",
Copy link
Contributor

@huydhn huydhn Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove 12.1 here to match https://github.com/pytorch/pytorch/blob/main/.github/scripts/generate_binary_build_matrix.py#L19?

Copy link
Contributor

@malfet malfet Dec 2, 2024 •
edited by atalman
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus one on the above..

@atalman wrote: Disabled auto-format in vscode. Sorry about this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its needed if you want to compile against torch release: https://github.com/pytorch/ao/actions/runs/12123278267

@clee2000
Copy link
Contributor

clee2000 commented Dec 2, 2024 •
edited
Loading

Do you mind rerunning python -m tools.tests.test_generate_binary_build_matrix --update-reference-files? It doesn't matter much, but I think most of the test file changes are just due to a change in the indentation

malfet
malfet reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like PR contains number of unrelated changes. More specifically, it feels weird to see test/assets updates for architectures that has nothing to do with the change

tools/scripts/generate_binary_build_matrix.py Outdated
"12.4": "pytorch/manylinux-builder:cuda12.4",
"12.6": "pytorch/manylinux2_28-builder:cuda12.6",
"11.8": "pytorch/manylinux-builder:cuda11.8",
"12.1": "pytorch/manylinux-builder:cuda12.1",
Copy link
Contributor

@malfet malfet Dec 2, 2024 •
edited by atalman
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus one on the above..

@atalman wrote: Disabled auto-format in vscode. Sorry about this

@atalman atalman merged commit 126c6fd into pytorch:main Dec 3, 2024
69 of 71 checks passed
@atalman atalman mentioned this pull request Dec 12, 2024
Open
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet left review comments

@zxiiro zxiiro zxiiro approved these changes

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@atalman @clee2000 @zxiiro @huydhn @malfet @facebook-github-bot