Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query to see jobs that need runners scaled up #5944

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

ZainRizvi
Copy link
Contributor

This will be used by the autoscaler lambdas to figure out which instances may not have properly propagated the scale-up command (which happens fairly regularly)

The query is based on the "queued_jobs" query, with a few changes:

  • Queues across all jobs in the pytorch and pytorch-labs organizations, which our runners support
  • Checks only a specific time window for queued jobs, looking for jobs that have been queued for long enough to warrant intervention, while not being so old that github cancels the job

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 11:36pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2024
@ZainRizvi ZainRizvi merged commit ea7177b into main Nov 19, 2024
7 checks passed
@ZainRizvi ZainRizvi deleted the zainr/queued-runner-query branch November 19, 2024 23:40
Copy link
Contributor

@clee2000 clee2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate if you could update this with a code pointer in the future for where you use this, otherwise there's a good chance I'm going to think it's not used anywhere since there are no references in test-infra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants