Enable GPU support for generic Windows job #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4571c6b.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
pmeier
commented
May 4, 2023
| @@ -126,12 +135,20 @@ jobs: | |||
| echo "/c/Jenkins/Miniconda3/python.exe -m pip install --upgrade pywin32==300" | |||
| # Source conda so it's available to the script environment | |||
| echo "source /c/Jenkins/Miniconda3/etc/profile.d/conda.sh"; | |||
| echo "${SCRIPT}"; | |||
| } > "${RUNNER_TEMP}/exec_script" | |||
| echo 'export PATH="/c/Jenkins/Miniconda3/Scripts:${PATH}"' | |||
There was a problem hiding this comment.
atalman
approved these changes
May 8, 2023
pmeier
commented
May 8, 2023
| timeout: 60 | ||
| script: | | ||
| conda create --yes --quiet -n test python=3.8 | ||
| conda activate test | ||
| python -m pip install --extra-index-url https://download.pytorch.org/whl/nightly/cu116 --pre torch | ||
| python -m pip install ---index-url=https://download.pytorch.org/whl/nightly/cu117 --pre torch |
There was a problem hiding this comment.
Problem here was that the CUDA 11.6 index no longer has any torch binaries. Since we additionally used --extra-index-url, we pulled the wheel from PyPI: https://github.com/pytorch/test-infra/actions/runs/4883695947/jobs/8715408340?pr=4104#step:9:86
And the Windows wheel on PyPI is not built against CUDA.
This is not related to this PR other than this PR triggered this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux job has these inputs to control the GPU support:
test-infra/.github/workflows/linux_job.yml
Lines 50 to 57 in 92814df
They were missing before from the Windows job. Without them, users are forced to use workarounds.
This PR adds them to the Windows job as well. Since we have multiple versions of CUDA already present on the AMI, we only need to set some paths.