Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop check and iter check for TensorDictKeysView #200

Merged
merged 15 commits into from
Feb 6, 2023

Conversation

ruleva1983
Copy link

Description

  • Added helper function for detection of loops in autonested case
  • Detailed test for the iter function of TensorDictKeysView

Motivation and Context

Test required to check the iteration functionality, specifically in the case of autonested that
each value is actually referenced only once

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Documentation (update in the documentation)
  • Tests
  • [ ]

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2023
Copy link
Contributor

@tcbegley tcbegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcbegley tcbegley merged commit de5cc92 into pytorch:auto-nested-tensordicts Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants