Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc,BugFix] Fix default argument in doc for AddStateIndependentNormalScale #1216

Merged
merged 1 commit into from
Feb 13, 2025
Merged

[Doc,BugFix] Fix default argument in doc for AddStateIndependentNormalScale #1216

merged 1 commit into from
Feb 13, 2025

Conversation

louisfaury
Copy link
Contributor

@louisfaury louisfaury commented Feb 10, 2025 •
edited
Loading

Description

The doc for AddStateIndependentNormalScale indicates of biased_softplus_1 as the default for the scale_mapping, while it is exp.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2025
@vmoens vmoens changed the title Fix default argument in doc for AddStateIndependentNormalScale [BugFix] Fix default argument in doc for AddStateIndependentNormalScale Feb 13, 2025
@vmoens vmoens added bug Something isn't working documentation Improvements or additions to documentation labels Feb 13, 2025
@vmoens vmoens changed the title [BugFix] Fix default argument in doc for AddStateIndependentNormalScale [Doc,BugFix] Fix default argument in doc for AddStateIndependentNormalScale Feb 13, 2025
vmoens
vmoens approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens merged commit 309c0a3 into pytorch:main Feb 13, 2025
1 check passed
vmoens pushed a commit that referenced this pull request Feb 17, 2025
@louisfaury @vmoens
[Doc,BugFix] Fix default argument in doc for `AddStateIndependentNorm…
3d02e49 
…alScale` (#1216)

Co-authored-by: Louis Faury <louis.faury@helsing.ai>
(cherry picked from commit 309c0a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louisfaury @vmoens @facebook-github-bot