Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bidirectional GRU and LSTM C++ API forward fix #22850

Closed
wants to merge 16 commits into from
Closed

Bidirectional GRU and LSTM C++ API forward fix #22850

wants to merge 16 commits into from

Conversation

pbelevich
Copy link
Contributor

Fixing #17998

@pbelevich pbelevich requested a review from zou3519 July 14, 2019 19:18
@zou3519
Copy link
Contributor

zou3519 commented Jul 15, 2019

You've unintentionally updated the submodule "third_party/fbgemm". I think you can cd into it and then check out the version that is supposed to be there.

zou3519
zou3519 reviewed Jul 15, 2019
View reviewed changes
test/cpp/api/rnn.cpp Outdated Show resolved Hide resolved
@pytorchbot pytorchbot added the module: cpp Related to C++ API label Jul 16, 2019
@pbelevich pbelevich requested a review from zou3519 July 21, 2019 19:30
@zou3519
Copy link
Contributor

zou3519 commented Jul 22, 2019

Tests aren't running, this might need a rebase

zou3519
zou3519 approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! Some minor comments on making the tests nicer.

test/cpp/api/rnn.cpp Show resolved Hide resolved
test/cpp/api/rnn.cpp Outdated Show resolved Hide resolved
test/cpp/api/rnn.cpp Outdated Show resolved Hide resolved
facebook-github-bot
facebook-github-bot reviewed Jul 22, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pbelevich merged this pull request in 965b97f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@yf225 yf225 yf225 left review comments

@zou3519 zou3519 zou3519 approved these changes

Assignees
No one assigned
Labels
Merged module: cpp Related to C++ API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pbelevich @zou3519 @facebook-github-bot @yf225 @pytorchbot @mruberry