-
Notifications
You must be signed in to change notification settings - Fork 23.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added base parameter to math.log #21151
Conversation
Sorry for continually remaking this PR, but I think I messed up something small with ghstack that causes this PR to be constantly remade. Can someone stamp this so I can hopefully stop constantly remaking this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here might fail the lint check
It passes the precommit lint check - I think it's fine. That code is also removed in a couple commits later in the stack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What happens if |
@xuhdev I've done that later up in the stack (I unified all the math tests and added much more exhaustive checkign): #21125 But to answer your question, we return |
Stack from ghstack:
Differential Revision: D15563185