Misleading documentation for module._load_from_state_dict #17618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssnl
approved these changes
Mar 1, 2019
f3cbfc5 to
ce6886a
Compare
) Summary: Pull Request resolved: pytorch#17618 Base on the code, we only add key to `missing_keys` and `unexpected_keys` if `$strict` is `True`. The documentation is confusing. This diff also fix one FLAKE8 warning. Reviewed By: ailzhang Differential Revision: D14280593 fbshipit-source-id: 605d8cf6499066f843fbf5556a1b106c8e41fda1
ce6886a to
d984fde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Base on the code, we only add key to
missing_keysandunexpected_keysif$strictisTrue. The documentation is confusing.This diff also fix one FLAKE8 warning.
Differential Revision: D14280593