Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update randomness.html #211

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Update randomness.html #211

merged 1 commit into from
Jun 3, 2019

Conversation

BramVanroy
Copy link
Contributor

@BramVanroy BramVanroy commented Jun 3, 2019

Following this question on the forums, I propose the following doc change. It clarifies that 'performance reduction' concerns the processing speed (and not the training accuracy).

@facebook-netlify-bot
Copy link

Deploy preview for pytorch-dot-org-preview ready!

Built with commit 86bddc1

https://deploy-preview-211--pytorch-dot-org-preview.netlify.com

@soumith
Copy link
Member

soumith commented Jun 3, 2019

thanks for sending this Bram.

Can you also additionally send a PR to https://github.com/pytorch/pytorch/blob/master/docs/source/notes/randomness.rst so that master docs (and all future docs are fixed)

@soumith soumith merged commit 2316440 into pytorch:site Jun 3, 2019
@BramVanroy BramVanroy deleted the BramVanroy-doc-performance-update branch June 4, 2019 08:04
@BramVanroy
Copy link
Contributor Author

I wasn't sure where I had to make those changes, indeed. Pull request for the docs here pytorch/pytorch#21337

facebook-github-bot pushed a commit to pytorch/pytorch that referenced this pull request Jun 4, 2019
Summary:
Following [this question on the forums](https://discuss.pytorch.org/t/reproducibility-and-performance/46504), I propose the following doc change. It clarifies that 'performance reduction' concerns the processing speed (and not the training accuracy).

Related website commit: pytorch/pytorch.github.io#211
Pull Request resolved: #21337

Differential Revision: D15622151

Pulled By: soumith

fbshipit-source-id: f0edeb20049f2ee715c400e7c57abb966864d621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants