Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add py.typed for type checkers #2095

Merged
merged 2 commits into from
Jul 4, 2021
Merged

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Jul 3, 2021

See colab.

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jul 3, 2021

For context:

If you use setuptools, you must pass the option zip_safe=False to setup(), or mypy will not be able to find the installed package.

@ydcjeff any thoughts about this note from mypy docs

Can you also add a test step similar to the one you have in the colab ?

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Jul 4, 2021

Can you also add a test step similar to the one you have in the colab ?

I think this is not needed once we confirm it is working.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jul 4, 2021

Can you also add a test step similar to the one you have in the colab ?

I think this is not needed once we confirm it is working.

There will be also failure for other domain libs like torchvision. OK for keeping this PR without test step.

Saw that MONAI does the same: Project-MONAI/MONAI#626

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ydcjeff !

@vfdev-5 vfdev-5 merged commit 43a6c6b into pytorch:master Jul 4, 2021
@ydcjeff ydcjeff deleted the fix/type branch July 4, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants