Move ReplaceScalarWithTensorArgPass to transforms #8519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pass is general and can be used by multiple backends. Use it in Arm backend and make small adjustments to make it work. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I61863d9cefb1753c604d67a6e44845af46ef7c60
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8519
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 Unrelated FailureAs of commit 8fcd2b2 with merge base 5e4d6b6 ( CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zingo
approved these changes
Feb 18, 2025
|
MacOs tests unrelated |
digantdesai
reviewed
Feb 19, 2025
| return self.get_replacement(op, args, kwargs, meta) | ||
|
|
||
|
|
||
| @register_cadence_pass(CadencePassAttribute(opt_level=0))( |
There was a problem hiding this comment.
causing a bunch of failures, I should be able to forward fix.
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 19, 2025
Summary: pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies. Differential Revision: D69883148
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 19, 2025
…ch#8588) Summary: Pull Request resolved: pytorch#8588 pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies. Reviewed By: swolchok Differential Revision: D69883148
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 20, 2025
…ch#8588) Summary: Pull Request resolved: pytorch#8588 pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies. Reviewed By: swolchok Differential Revision: D69883148
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 20, 2025
… fix type annotations Summary: pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies. Also fix some type annotations; the Meta-internal type checker seems to be more strict. Reviewed By: swolchok Differential Revision: D69883148
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 20, 2025
… fix type annotations (pytorch#8588) Summary: Pull Request resolved: pytorch#8588 pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies. Also fix some type annotations; the Meta-internal type checker seems to be more strict. Reviewed By: swolchok Differential Revision: D69883148
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 21, 2025
… fix type annotations (pytorch#8588) Summary: Pull Request resolved: pytorch#8588 pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies. Also fix some type annotations; the Meta-internal type checker seems to be more strict. Reviewed By: swolchok Differential Revision: D69883148
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 21, 2025
… fix type annotations (pytorch#8588) Summary: Pull Request resolved: pytorch#8588 pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies. Also fix some type annotations; the Meta-internal type checker seems to be more strict. Reviewed By: swolchok Differential Revision: D69883148
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 21, 2025
… fix type annotations (pytorch#8588) Summary: Pull Request resolved: pytorch#8588 pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies. Also fix some type annotations; the Meta-internal type checker seems to be more strict. Reviewed By: swolchok Differential Revision: D69883148
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 21, 2025
… fix type annotations (pytorch#8588) Summary: Pull Request resolved: pytorch#8588 pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies. Also fix some type annotations; the Meta-internal type checker seems to be more strict. Reviewed By: swolchok Differential Revision: D69883148
dbort
added a commit
to dbort/executorch
that referenced
this pull request
Feb 21, 2025
… fix type annotations (pytorch#8588) Summary: Pull Request resolved: pytorch#8588 pytorch#8519 (D69765463) adds this new module. Update the buck deps to reflect the new dependencies. Also fix some type annotations; the Meta-internal type checker seems to be more strict. Reviewed By: swolchok Differential Revision: D69883148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pass is general and can be used by multiple backends. Use it in Arm backend and make small adjustments to make it work.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218