Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devtool] make datasink as a sepreate directory #8514

Open
wants to merge 3 commits into
base: gh/gasoonjia/3/base
Choose a base branch
from

Conversation

Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Feb 17, 2025

Stack from ghstack (oldest at bottom):

this diff make data_sink_base and its childrens as a seperate directory for better structure.

Differential Revision: D69732404

this diff make data_sink_base and its childrens as a seperate directory for better structure.

Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Feb 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8514

Note: Links to docs will display an error until the docs builds have been completed.

❌ 29 New Failures, 4 Unrelated Failures

As of commit ffad592 with merge base 9de9ed4 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69732404

Gasoonjia added a commit that referenced this pull request Feb 17, 2025
this diff make data_sink_base and its childrens as a seperate directory for better structure.

Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/)

ghstack-source-id: 266774369
Pull Request resolved: #8514
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

this diff make data_sink_base and its childrens as a seperate directory for better structure.

Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69732404

Gasoonjia added a commit that referenced this pull request Feb 17, 2025
Pull Request resolved: #8514

this diff make data_sink_base and its childrens as a seperate directory for better structure.

Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/)
ghstack-source-id: 266868291
this diff make data_sink_base and its childrens as a seperate directory for better structure.

Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69732404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants