Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add pass for replacing dq-q patterns with rescale" #8480

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

zingo
Copy link
Collaborator

@zingo zingo commented Feb 13, 2025

Reverts #8415
Due to braking testing

cc @digantdesai @freddan80 @per @oscarandersson8218

Copy link

pytorch-bot bot commented Feb 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8480

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8f58acf with merge base 0dfd1c0 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 13, 2025
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing and removed topic: not user facing labels Feb 13, 2025
@zingo
Copy link
Collaborator Author

zingo commented Feb 13, 2025

@digantdesai or @dbort or @mergennachin sorry to disturb you but Im not allowed to selfreview this

@dbort
Copy link
Contributor

dbort commented Feb 14, 2025

Thank you for reverting this! Sorry I didn't see it earlier

@dbort dbort merged commit 94d8036 into main Feb 14, 2025
109 of 113 checks passed
@dbort dbort deleted the revert-8415-quantize_to_int32 branch February 14, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants