Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .ptd support to extension/module #8421

Merged
merged 1 commit into from
Feb 20, 2025
Merged

add .ptd support to extension/module #8421

merged 1 commit into from
Feb 20, 2025
+149 −36

Conversation

JacobSzwejbka
Copy link
Contributor

Summary: Title

Differential Revision: D69478424

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8421

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit fbf4d00 with merge base b6ffe1a (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

@JacobSzwejbka JacobSzwejbka added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: extension Issues related to code under extension/ release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) labels Feb 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 12, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
eae181c 
Summary:
Pull Request resolved: pytorch#8421

Title

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 12, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
df7e862 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 12, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
bff6e5a 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 12, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
83ceb0f 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 12, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
3eacb5e 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 12, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
4a5e0f2 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 12, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
b28fe99 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 19, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
ab625d3 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 19, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
b187aaa 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 19, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
2b8ac5e 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 19, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
8e252db 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 19, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
fea3702 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 19, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
74cbd19 
Summary:
Pull Request resolved: pytorch#8421

Title

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Feb 19, 2025
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
8977df0 
Summary:
Pull Request resolved: pytorch#8421

Add support for passing in a .ptd to extension/module

Reviewed By: lucylq

Differential Revision: D69478424
@JacobSzwejbka @facebook-github-bot
add .ptd support to extension/module (pytorch#8421)
fbf4d00 
Summary:
Pull Request resolved: pytorch#8421

Add support for passing in a .ptd to extension/module

Reviewed By: lucylq

Differential Revision: D69478424
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69478424

@facebook-github-bot facebook-github-bot merged commit 3e188fe into pytorch:main Feb 20, 2025
55 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucylq lucylq lucylq approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: extension Issues related to code under extension/ release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacobSzwejbka @facebook-github-bot @lucylq