Upgrade actions/download-artifact@v4 #7573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7573
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 PendingAs of commit e06fcab with merge base e1c0bcf ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
JacobSzwejbka
approved these changes
Jan 9, 2025
huydhn
commented
Jan 9, 2025
| @@ -53,7 +53,7 @@ jobs: | |||
| ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} | |||
| timeout: 90 | |||
| secrets-env: BUILD_CERTIFICATE_BASE64 EXECUTORCH_DEMO_BUILD_PROVISION_PROFILE_BASE64 KEYCHAIN_PASSWORD | |||
| upload-artifact: ios-apps | |||
| upload-artifact: ios-demo-app | |||
There was a problem hiding this comment.
Changing the upload artifact name here is needed to address actions/upload-artifact#480. In v4, we couldn't upload multiple artifacts with the same name anymore.
This was referenced Jan 10, 2025
|
@pytorchbot cherry-pick --onto release/0.5 -c regression |
pytorchbot
pushed a commit
that referenced
this pull request
Jan 22, 2025
* Upgrade actions/download-artifact@v4 * Address actions/upload-artifact#480 (cherry picked from commit 478198b)
Cherry picking #7573The cherry pick PR is at #7860 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
huydhn
added a commit
that referenced
this pull request
Jan 23, 2025
Upgrade actions/download-artifact@v4 (#7573) * Upgrade actions/download-artifact@v4 * Address actions/upload-artifact#480 (cherry picked from commit 478198b) Co-authored-by: Huy Do <huydhn@gmail.com>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Upgrade actions/download-artifact@v4 * Address actions/upload-artifact#480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/,
v3will hard fail now pytorch/pytorch#144479