Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move type arg to the end to match Aten constructors. #5379

Closed
wants to merge 1 commit into from
Closed

Move type arg to the end to match Aten constructors. #5379

wants to merge 1 commit into from

Conversation

shoumikhin
Copy link
Contributor

Summary: .

Differential Revision: D62701089

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5379

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 932964e with merge base 0a501eb (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62701089

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62701089

2 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62701089

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62701089

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62701089

4 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62701089

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62701089

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62701089

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62701089

@shoumikhin @facebook-github-bot
Move type arg to the end to match Aten constructors. (#5379)
932964e 
Summary:
Pull Request resolved: #5379

.

Reviewed By: kirklandsign

Differential Revision: D62701089
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62701089

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c252553.

@shoumikhin
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Sep 16, 2024
@shoumikhin @pytorchbot
Move type arg to the end to match Aten constructors. (#5379)
e8c906e 
Summary:
Pull Request resolved: #5379

.

Reviewed By: kirklandsign

Differential Revision: D62701089

fbshipit-source-id: 3f05961a43db9e6e372ee039c2d832227951fbf6
(cherry picked from commit c252553)
@pytorchbot
Copy link
Collaborator

Cherry picking #5379

The cherry pick PR is at #5391 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Sep 16, 2024
Closed
jackzhxng pushed a commit that referenced this pull request Sep 17, 2024
@pytorchbot @shoumikhin
Move type arg to the end to match Aten constructors. (#5391)
b5f7b85 
Move type arg to the end to match Aten constructors. (#5379)

Summary:
Pull Request resolved: #5379

.

Reviewed By: kirklandsign

Differential Revision: D62701089

fbshipit-source-id: 3f05961a43db9e6e372ee039c2d832227951fbf6
(cherry picked from commit c252553)

Co-authored-by: Anthony Shoumikhin <shoumikhin@meta.com>
Co-authored-by: Anthony Shoumikhin <anthony@shoumikh.in>
lucylq pushed a commit that referenced this pull request Sep 17, 2024
@shoumikhin @lucylq
Move type arg to the end to match Aten constructors. (#5379)
145a3cd 
Summary:
Pull Request resolved: #5379

.

Reviewed By: kirklandsign

Differential Revision: D62701089

fbshipit-source-id: 3f05961a43db9e6e372ee039c2d832227951fbf6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shoumikhin @facebook-github-bot @pytorchbot @kirklandsign