NotImplementedError: Model's DEFAULT_TRAIN_BSIZE is not implemented. #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
reviewed
Jan 7, 2025
| @@ -129,6 +129,7 @@ class Model(BenchmarkModel): | |||
| # Source: https://github.com/dionhaefner/pyhpc-benchmarks/blob/650ecc650e394df829944ffcf09e9d646ec69691/run.py#L25 | |||
| # Pick data-point when i = 20, size = 1048576 | |||
| DEFAULT_EVAL_BSIZE = 1048576 | |||
| DEFAULT_TRAIN_BSIZE = 1048576 | |||
There was a problem hiding this comment.
We do not need to add train bsize because the train() function is not implemented or supported by this model.
e72142d to
e6fde3b
Compare
512fbdd to
f421586
Compare
|
@xuzhao9 Yes, you're right. Most of the classes have a train method but they return only an exception. I have to take it into account while testing. But still, there's one model that has an implemented train method without DEFAULT_TRAIN_BSIZE field. I updated my PR. Can you take a look, please? |
|
@xuzhao9 could you assign anyone else if you're busy? |
xuzhao9
approved these changes
Feb 18, 2025
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xuzhao9 thanks for approval. Can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests fail in train mode. I found missing fields in specific models and added DEFAULT_TRAIN_BSIZE with the same value as eval batch size.