Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump transformers from 4.36.0 to 4.38.1 #2179

Closed
wants to merge 1 commit into from
Closed

Conversation

angelayi
Copy link
Contributor

A previous transformers update to torchbench (pytorch/pytorch#117073) resulted in some failures on the TorchInductor benchmarks (pytorch/pytorch#117280).

A fix was made to transformers (huggingface/transformers#27871), which was released in transformers version 4.38.0, so I would like to bump the version in torchbench so that we can fix the issue with the Inductor benchmarks.

Please let me know if there are any procedures I should go through for this update!

@xuzhao9
Copy link
Contributor

xuzhao9 commented Feb 26, 2024

Thanks for the contribution!

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@angelayi merged this pull request in 1ef0a39.

pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Mar 5, 2024
Fixes #117280 after bumping the HF version in pytorch/benchmark#2179

Pull Request resolved: #121029
Approved by: https://github.com/desertfire
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants