Skip to content

Commit

Permalink
disable cudagraph for tts_angular on dashboard (#148221)
Browse files Browse the repository at this point in the history
Summary:
tts_angular with cudagraph is flaky. Its speedup varies from .05 to 1.01. This PR disables cudagraph for tts_angular to avoid the noise. Since tts_angular shows ~1x speedup while other torchbench models show ~2x speedup, skipping tts_angular would wrongly bump the cudagraph speedup. So this PR only disables cudagraph for tts_angular instead of skipping tts_angular.

[Dashboard ](https://github.com/pytorch/pytorch/actions/runs/13597394087)

X-link: pytorch/pytorch#148221
Approved by: https://github.com/eellison

Reviewed By: wdvr

Differential Revision: D70457614

fbshipit-source-id: 5602662d54b4bcff7e01abc3ea5c26a63767831b
  • Loading branch information
BoyuanFeng authored and facebook-github-bot committed Mar 2, 2025
1 parent ee78538 commit 182024e
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 0 deletions.
7 changes: 7 additions & 0 deletions userbenchmark/dynamo/dynamobench/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -1824,6 +1824,10 @@ def skip_multiprocess_models(self):
def skip_models_due_to_control_flow(self):
return set()

@property
def disable_cudagraph_models(self):
return set()

@property
def guard_on_nn_module_models(self):
return set()
Expand Down Expand Up @@ -3834,6 +3838,9 @@ def model_iter_fn_and_mark_step(*args, **kwargs):
experiment = coverage_experiment
output_filename = "coverage.csv"

if args.only in runner.disable_cudagraph_models:
args.disable_cudagraphs = True

if args.inductor or args.backend == "inductor" or args.export_aot_inductor:
inductor_config.triton.cudagraphs = not args.disable_cudagraphs
inductor_config.triton.persistent_reductions = (
Expand Down
4 changes: 4 additions & 0 deletions userbenchmark/dynamo/dynamobench/torchbench.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ def skip_models_for_cuda(self):
def skip_models_for_freezing_cuda(self):
return self._skip["freezing"]["cuda"]

@property
def disable_cudagraph_models(self):
return self._config["disable_cudagraph"]

@property
def skip_models_for_freezing_cpu(self):
return self._skip["freezing"]["cpu"]
Expand Down
6 changes: 6 additions & 0 deletions userbenchmark/dynamo/dynamobench/torchbench.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ non_deterministic:
- sam_fast


disable_cudagraph:
# tts_angular is flaky with cudagraphs. Its speedup
# oscillates from .05 to 1.05
- tts_angular


dtype:
force_amp_for_fp16_bf16_models:
- DALLE2_pytorch
Expand Down

0 comments on commit 182024e

Please sign in to comment.