Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the logic to initialize sox #3654

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

moto-meta
Copy link
Contributor

Differential Revision: D50197331

@moto-meta moto-meta requested a review from a team as a code owner October 12, 2023 23:54
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 12, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3654

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ca2e52f with merge base f62367a (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50197331

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50197331

facebook-github-bot pushed a commit that referenced this pull request Oct 13, 2023
Summary:

Adopt lazy initialization to sox extension and get rid of fail_if decorators.

Differential Revision: D50197331
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50197331

Summary:

Adopt lazy initialization to sox extension and get rid of fail_if decorators.

Differential Revision: D50197331
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50197331

@facebook-github-bot facebook-github-bot merged commit dde08ba into main Oct 13, 2023
@facebook-github-bot facebook-github-bot deleted the export-D50197331 branch October 13, 2023 17:20
@github-actions
Copy link

Hey @None.
You merged this PR, but labels were not properly added. Please add a primary and secondary label (See https://github.com/pytorch/audio/blob/main/.github/process_commit.py).


Some guidance:

Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss).

Things in "examples" directory:

  • 'recipe' is applicable to training recipes under the 'examples' folder,
  • 'tutorial' is applicable to tutorials under the “examples/tutorials” folder
  • 'example' is applicable to everything else (e.g. C++ examples)
  • 'module: docs' is applicable to code documentations (not to tutorials).

Regarding examples in code documentations, please also use 'module: docs'.

Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes.


When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'.

Things related to build are by default excluded from the release note, except when it impacts users. For example:
* Drop support of Python 3.7.
* Add support of Python 3.X.
* Change the way a third party library is bound (so that user needs to install it separately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants