-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the logic to initialize sox #3654
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3654
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit ca2e52f with merge base f62367a (): FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D50197331 |
64c12ac
to
8d20fed
Compare
This pull request was exported from Phabricator. Differential Revision: D50197331 |
Summary: Adopt lazy initialization to sox extension and get rid of fail_if decorators. Differential Revision: D50197331
8d20fed
to
fa2a969
Compare
This pull request was exported from Phabricator. Differential Revision: D50197331 |
Summary: Adopt lazy initialization to sox extension and get rid of fail_if decorators. Differential Revision: D50197331
fa2a969
to
ca2e52f
Compare
This pull request was exported from Phabricator. Differential Revision: D50197331 |
Hey @None. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Regarding examples in code documentations, please also use 'module: docs'. Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
Differential Revision: D50197331