Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fp8 conversion kernel that writes both row and column major outputs #1494

Merged
merged 10 commits into from
Jan 7, 2025
Merged

add fp8 conversion kernel that writes both row and column major outputs #1494

merged 10 commits into from
Jan 7, 2025

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Jan 3, 2025 •
edited
Loading

No description provided.

@danielvegamyhre
Update
f85618f 
[ghstack-poisoned]
@danielvegamyhre
Update
c603139 
[ghstack-poisoned]
@danielvegamyhre
Update
9b42e69 
[ghstack-poisoned]
@danielvegamyhre
Update
fc301fd 
[ghstack-poisoned]
@danielvegamyhre
Copy link
Contributor Author

danielvegamyhre commented Jan 3, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1494

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit a6becf8 with merge base 84401dd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jan 3, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jan 3, 2025
@danielvegamyhre danielvegamyhre requested a review from vkuzo January 3, 2025 21:53
danielvegamyhre added a commit to danielvegamyhre/ao that referenced this pull request Jan 6, 2025
@danielvegamyhre
add fp8 conversion kernel that writes both row and column major outputs
6fa71e4 
ghstack-source-id: c33e1a7460fb23f3a7ce98fe6186e5f1faa8251e
ghstack-comment-id: 2569853060
Pull Request resolved: pytorch#1494
@danielvegamyhre danielvegamyhre mentioned this pull request Jan 7, 2025
Merged
@danielvegamyhre
Update
2bbdf88 
[ghstack-poisoned]
@danielvegamyhre
Update
58be437 
[ghstack-poisoned]
@danielvegamyhre
Update
25298cb 
[ghstack-poisoned]
@danielvegamyhre
Update
ddf1efc 
[ghstack-poisoned]
@danielvegamyhre
Update
0536cb8 
[ghstack-poisoned]
@danielvegamyhre danielvegamyhre mentioned this pull request Jan 7, 2025
Merged
@danielvegamyhre
Update
a6becf8 
[ghstack-poisoned]
@danielvegamyhre danielvegamyhre changed the base branch from gh/danielvegamyhre/11/head to main January 7, 2025 20:52
@danielvegamyhre danielvegamyhre merged commit cd62874 into main Jan 7, 2025
44 checks passed
amdfaa pushed a commit that referenced this pull request Jan 10, 2025
@danielvegamyhre @amdfaa
add fp8 conversion kernel that writes both row and column major outpu…
f60208b 
…ts (#1494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkuzo vkuzo vkuzo approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielvegamyhre @vkuzo @facebook-github-bot