Skip to content

Commit

Permalink
Add ruff config options in actiosn to ruff toml (#1453)
Browse files Browse the repository at this point in the history
stack-info: PR: #1453, branch: drisspg/stack/23
  • Loading branch information
drisspg authored Dec 20, 2024
1 parent 84fb834 commit 692236a
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 12 deletions.
24 changes: 12 additions & 12 deletions .github/workflows/ruff_linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
permissions:
contents: write
pull-requests: write

strategy:
matrix:
python-version: ["3.9"]
Expand All @@ -33,43 +33,43 @@ jobs:
PR_URL=${{ github.event.inputs.pr_url }}
PR_NUMBER=$(echo $PR_URL | grep -oE '[0-9]+$')
echo "PR_NUMBER=$PR_NUMBER" >> $GITHUB_ENV
- uses: actions/checkout@v3
if: github.event_name == 'workflow_dispatch'
with:
fetch-depth: 0
token: ${{ secrets.GITHUB_TOKEN }}

- name: Checkout PR branch
if: github.event_name == 'workflow_dispatch'
run: |
gh pr checkout ${{ env.PR_NUMBER }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/checkout@v3
if: github.event_name != 'workflow_dispatch'
with:
fetch-depth: 0

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v3
with:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install ruff==0.6.8
- name: Regular lint check
if: github.event_name != 'workflow_dispatch'
run: |
ruff check .
# --isolated is used to skip the allowlist at all so this applies to all files
# please be careful when using this large changes means everyone needs to rebase
# if you do be sure to update .pre-commit-config.yaml
ruff check --isolated --select F821,F823,W191
ruff check --select F,I
ruff check
ruff format --check || {
echo "Ruff check failed, please try again after running 'ruff format'."
exit 1
Expand All @@ -80,11 +80,11 @@ jobs:
run: |
git config --global user.name 'github-actions[bot]'
git config --global user.email 'github-actions[bot]@users.noreply.github.com'
# Apply fixes
ruff check --select F,I --fix
ruff check --fix
ruff format .
# Commit and push if there are changes
if [[ -n "$(git status --porcelain)" ]]; then
git add .
Expand Down
6 changes: 6 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,9 @@ repos:
- F,I
# Run the formatter.
- id: ruff-format
# Run isolated checks.
- id: ruff
alias: ruff-isolated
args:
- --isolated
- select F821,F823,W191
1 change: 1 addition & 0 deletions ruff.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@ include = [
"test/prototype/low_bit_optim/**.py",
]

lint.select = ["F", "I"]
lint.ignore = ["E731"]

0 comments on commit 692236a

Please sign in to comment.