Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutable module improvement #3394

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

cehongwang
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@cehongwang cehongwang self-assigned this Feb 13, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Feb 13, 2025
@github-actions github-actions bot requested a review from gs-olive February 13, 2025 00:23
@cehongwang cehongwang force-pushed the mutable_module_improvement branch 2 times, most recently from 210bd3a to 02011eb Compare February 13, 2025 00:30
@github-actions github-actions bot removed documentation Improvements or additions to documentation component: lowering Issues re: The lowering / preprocessing passes labels Feb 13, 2025
@cehongwang cehongwang force-pushed the mutable_module_improvement branch 3 times, most recently from f183050 to 9580f92 Compare February 13, 2025 21:22
@cehongwang cehongwang force-pushed the mutable_module_improvement branch from 3db0aec to ec2d674 Compare February 15, 2025 00:39
@cehongwang cehongwang removed the request for review from gs-olive February 18, 2025 18:53
@cehongwang cehongwang force-pushed the mutable_module_improvement branch from 0ca42f3 to 0643d96 Compare February 18, 2025 22:40
@cehongwang cehongwang force-pushed the mutable_module_improvement branch 6 times, most recently from a5ea97b to a59d92d Compare February 20, 2025 23:04
@cehongwang cehongwang force-pushed the mutable_module_improvement branch from a59d92d to a8e0b48 Compare February 21, 2025 18:49
@github-actions github-actions bot added the component: conversion Issues re: Conversion stage label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants