Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests-py-dynamo-cudagraphs in Windows test #3096

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

HolyWu
Copy link
Contributor

@HolyWu HolyWu commented Aug 17, 2024

Description

  • Fix incorrect yml and pre-script being used in tests-py-dynamo-cudagraphs.
  • Add -ra argument to remaining tests.
  • Make -n argument consistent with Linux test.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 2f3ae2f into pytorch:main Aug 21, 2024
48 of 67 checks passed
@HolyWu HolyWu deleted the fix_cudagraphs_test branch August 21, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants