Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing slice scatter and select scatter decomposition #3093

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented Aug 17, 2024

Addresses #3064

@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Aug 17, 2024
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044
Copy link
Collaborator

peri044 commented Aug 21, 2024

Can you rebase?

@apbose apbose force-pushed the select_scatter_decomp_index_device_change branch from f43302f to 6cdcec5 Compare August 22, 2024 23:45
@apbose apbose force-pushed the select_scatter_decomp_index_device_change branch from 6cdcec5 to 46673a6 Compare August 29, 2024 18:10
@peri044 peri044 merged commit 3a3d62a into main Aug 29, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants