-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Address some issues with enums and overhaul documentation #2974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/docsrc/conf.py 2024-07-01 17:10:40.348842+00:00
+++ /home/runner/work/TensorRT/TensorRT/docsrc/conf.py 2024-07-01 17:12:30.584635+00:00
@@ -187,11 +187,11 @@
"ConverterImplSignature": "ConverterImplSignature",
}
nbsphinx_execute = "never"
-autodoc_member_order = 'groupwise'
+autodoc_member_order = "groupwise"
# -- A patch that prevents Sphinx from cross-referencing ivar tags -------
# See http://stackoverflow.com/a/41184353/3343043
from docutils import nodes
1b07c16
to
cf5cc93
Compare
I suggest that you can add a codespell workflow which is quite handy for checking common misspellings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/utils.py 2024-07-02 18:31:52.897696+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/utils.py 2024-07-02 18:44:37.254421+00:00
@@ -369,10 +369,11 @@
return f(*args, **kwargs)
return function_wrapper
return nested_decorator
+
def check_output(
new_module: torch.fx.GraphModule,
refitted_module: torch.fx.GraphModule,
inputs: tuple[Any, ...],
@@ -383,6 +384,6 @@
new_outputs, torch.Tensor
):
if not torch.allclose(old_output, new_output, 1e-2, 1e-2):
return False
- return True
\ No newline at end of file
+ return True
62c9588
to
929a4ba
Compare
Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com> ci: Adding typos pre-commit Signed-off-by: Naren Dasan <naren@narendasan.com> Signed-off-by: Naren Dasan <narens@nvidia.com>
929a4ba
to
943ef05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Addresses some issues with enums and refactors the documentation to more clearly reflect the current state of the project
Fixes #2902
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: