Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing select in Bazel BUILD #2966

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

gs-olive
Copy link
Collaborator

Description

  • Add back missing select calls in Bazel BUILDs

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive requested a review from apbose June 28, 2024 17:33
@gs-olive gs-olive self-assigned this Jun 28, 2024
@github-actions github-actions bot added the component: tests Issues re: Tests label Jun 28, 2024
@github-actions github-actions bot requested a review from narendasan June 28, 2024 17:33
@gs-olive gs-olive merged commit 058ee5c into pytorch:main Jun 29, 2024
3 checks passed
@gs-olive gs-olive deleted the add_missing_windows_selects_bazel branch June 29, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants