Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dynamic shape support for atan/asinh/acosh/atanh/atan2/ceil #2959

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat: dynamic shape support for atan/asinh/acosh/atanh/atan2/ceil #2959

merged 1 commit into from
Jul 3, 2024

Conversation

keehyuna
Copy link
Collaborator

Description

dynamic shape support for atan/asinh/acosh/atanh/atan2/ceil

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 26, 2024
@github-actions github-actions bot requested a review from peri044 June 26, 2024 08:19
@keehyuna keehyuna force-pushed the atan_dynamic_shape branch from ba94ae7 to aefcd89 Compare June 26, 2024 11:40
peri044
peri044 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending linting fix

zewenli98
zewenli98 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keehyuna keehyuna force-pushed the atan_dynamic_shape branch from aefcd89 to bf83522 Compare July 1, 2024 02:15
@keehyuna keehyuna self-assigned this Jul 2, 2024
@keehyuna keehyuna merged commit f5167a8 into pytorch:main Jul 3, 2024
55 of 61 checks passed
cehongwang pushed a commit that referenced this pull request Jul 8, 2024
@keehyuna @cehongwang
feat: dynamic shape support for atan/asinh/acosh/atanh/atan2/ceil (#2959
2fb7453 
)
@keehyuna keehyuna deleted the atan_dynamic_shape branch August 19, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@narendasan narendasan Awaiting requested review from narendasan

@chohk88 chohk88 Awaiting requested review from chohk88

@zewenli98 zewenli98 Awaiting requested review from zewenli98

Assignees

@keehyuna keehyuna

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keehyuna @peri044 @zewenli98 @facebook-github-bot