-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bug in elementwise base for static inputs #2819
Conversation
This looks good to me. It seems like it could resolve the CI/CD issues mentioned in 2726 |
It seems that we've encountered an accuracy issue in the CI/CD test, which wasn't quite what we expected. Could this be the error you mentioned occurring in TRT-10? |
…hape in elementwise.base
@chohk88 Yes that's it! The issue here is that the original For example, we have original ITensors: lhs_val.shape: (2, 3) rhs_val.shape: (2, 2, 1, 3)
I think this fix should also work for #2726 |
This looks good to me. |
@peri044 Is this PR needed to be cherry-picked to |
Description
Fixes #2774 #2726
Type of change
Checklist: