Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up AWS credentials #2589

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Clean up AWS credentials #2589

merged 1 commit into from
Jan 14, 2024

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Jan 12, 2024

The credential has been revoked to be replaced by OIDC pytorch/test-infra#4865

@gs-olive
Copy link
Collaborator

Hi @huydhn - thank you for the PR. Are cases such as the following also affected? These workflows seem to be failing as well on recent runs:
Failure for below GHA

repo-token: "${{ secrets.GITHUB_TOKEN }}"

Failure for below GHA
repo-token: "${{ secrets.GITHUB_TOKEN }}"

@huydhn
Copy link
Contributor Author

huydhn commented Jan 12, 2024

Hi @huydhn - thank you for the PR. Are cases such as the following also affected? These workflows seem to be failing as well on recent runs: Failure for below GHA

repo-token: "${{ secrets.GITHUB_TOKEN }}"

Failure for below GHA

repo-token: "${{ secrets.GITHUB_TOKEN }}"

Oh, they need to be fixes, but in a different ways by granting write access to the token. The context here is that the token default write access has been revoked, so they will need to be grant explicitly. Let me submit a PR real quick.

@huydhn
Copy link
Contributor Author

huydhn commented Jan 12, 2024

@gs-olive This should help fix the issue #2591

@gs-olive
Copy link
Collaborator

Great - thank you for adding that PR! Will take a look

@huydhn huydhn merged commit ec2ebb3 into main Jan 14, 2024
20 of 22 checks passed
@huydhn
Copy link
Contributor Author

huydhn commented Jan 14, 2024

Opps, I think I accidentally closed this when merging #2591, will create another PR to replace this one then

@huydhn huydhn deleted the cleanup-aws-credentials branch January 14, 2024 06:56
@huydhn huydhn restored the cleanup-aws-credentials branch January 14, 2024 06:56
@huydhn huydhn deleted the cleanup-aws-credentials branch January 14, 2024 06:56
@huydhn huydhn mentioned this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants